forked from Kazuhito00/Image-Processing-Node-Editor
-
Notifications
You must be signed in to change notification settings - Fork 0
Standardize queue management and info display across input nodes #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
234
commits into
main
Choose a base branch
from
copilot/modify-node-inputs-queue-management
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Fix audio merge crash on recording stop and validate empty audio samples
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
…eature Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
…on-tracker Add hand tracking node for MediaPipe Hands pose estimation
- Add timestamp preservation in ImageConcat when collecting audio from multiple slots - Update VideoWriter to synchronize multi-slot audio by timestamp instead of slot order - Add comprehensive tests validating synchronized audio merging - Maintain backward compatibility for audio without timestamps Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
- Move traceback import to top of file
- Add detailed comment for float('inf') usage in timestamp sorting
- Remove specific line numbers from documentation to prevent staleness
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
[WIP] Verify synchronized merging of audio chunks
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
…Writer Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
… review Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
…ssues Fix audio timestamp loss in Video→SyncQueue→ImageConcat→VideoWriter pipeline
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
…ssing Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
…orker Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
[WIP] Implement background video creation to avoid UI freezes
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Fix AVI video slow playback by re-encoding to H.264
… issues Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
…ility Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Fix VFR video audio distortion and timing issues using ffprobe for accurate FPS extraction
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
…rove comments Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
…n-video Verify and document audio priority workflow in VideoWriter
…ube) Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
…one node Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Modify node inputs for video handling and queue management
Standardize queue management and info display across input nodes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input nodes (webcam, rtsp, microphone, youtube, api, webrtc) lacked consistent queue management and visibility compared to the video node, making it difficult to monitor queue health and identify bottlenecks.
Changes
Added queue info display to all input nodes
Image=X/Y Audio=Z/Wformat (current/max capacity)Refactored to shared utility method
Optimized queue info retrieval
Verified queue compatibility
get_input_frame()with QueueBackedDictDEFAULT_QUEUE_SIZE = 800with automatic eviction prevents unbounded growthExample
Before: No visibility into queue state
After: Queue info updated and displayed
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.